vios module - fails with lpar_env=vioserver in settings

[michaelquaranta]

Yes I understand that it is implicit in the vios command module that the lpar_env should be "vioserver". But I don't think this should be a failure condition.

However the documentation states:

settings
        To configure various supported attributes of VIOS partition.
        Supports all the attributes available for creation of VIOS on the mksyscfg command.

I would prefer this does not fail in my playbook if it is defined in settings.

Or the documentation should be changed?

example:

ansible localhost -m ibm.power_hmc.vios -a 'hmc_host=myhmc hmc_auth={"username":"hscroot","password":"abcd1234"} system_name=kurtkP8 name=myvios state=present settings={"lpar_env":"vioserver"}'
localhost | FAILED! => {
    "changed": false,
    "msg": "ParameterError: Invalid parameters: lpar_env"
}

from vios.py:

# Collection of attributes not supported by vios partition
not_support_settings = ['lpar_env', ...

[AnilVijayan]

As you have mentioned this settings is implicit. Will improve the documentation