Closed christiancompton closed 6 years ago
@sanjeevghimire - Given that the authentication changes here did work locally, are you okay with merging it in, or do you need a full end-to-end test with downloading the model to proceed?
Edit: Tagged wrong Sanjeev!
@christiancompton I am testing another round for the workshop. once that works, I will merge it.
@stevemart @sanjeevghimire The comment above has been addressed.
This PR adds logic for IAM authentication using IAM credentials and the new initializer from the Watson SDK for these credential sets. It keeps backwards compatibility with the previous authentication paradigm, which still need to be supported for users in certain availability zones, as well as users who are trying to connect existing service instances with the old credentials.
I will coordinate with @sanjeevghimire for testing & merging.