Add Restkit to project configuration

IBM / ar-resume-with-visual-recognition

An augmented reality based résumé with Face recognition. The iOS app recognizes the face and presents you with the AR view that contains 3D mock face and details of your resume.

https://developer.ibm.com/patterns/create-an-augmented-reality-application-with-facial-detection/

Apache License 2.0

73 stars 26 forks source link

Add Restkit to project configuration #43

Closed christiancompton closed 5 years ago

christiancompton commented 5 years ago

This PR addresses some problems with the project.

When upgrading to the Watson 1.0 SDK, RestKit was added as its own framework - this adds it automatically to the .xcproj
Cleaning of log/print statements
Swift 4.2 conversion

christiancompton commented 5 years ago

I'm seeing the app crash shortly after starting - I'll try to investigate the threading, but that may be out of scope for this PR.

stevemar commented 5 years ago

This is a good start, thanks for letting us know about the legacy api_key authentication being removed. If you can't figure out why the app crashes we'll re-evaluate if it's an issue with this change or if it's happening in master.

christiancompton commented 5 years ago

@stevemart This crash is happening in master. Back in April, I was attributing this error to the old processor on the iPhone 6S I was using, but I have access to an iPhone X now, and was able to replicate. Can you have someone investigate this?

stevemar commented 5 years ago

@christiancompton thanks for confirming it happens on master.

@sanjeevghimire can you look into this?

@christiancompton think we should merge your changes anyway or will that just make things harder to debug 🤔 ?

christiancompton commented 5 years ago

I am finishing some of the error logging improvements still - should be done shortly.