search

IBM / aspera-sdk-js

IBM Aspera for Desktop JavaScript SDK
https://ibm.github.io/aspera-sdk-js/docs
Apache License 2.0
0 stars 0 forks source link

fix: revert desktop spec rename #44

Closed JAHMCR closed 3 weeks ago

JAHMCR commented 3 weeks ago

Revert DesktopSpec mistakenly renamed to BrowserSpec

dabrad26 commented 3 weeks ago

I think we can keep this name. But the desktop_spec in payload needs to be fixed. Pushed that already. But BrowserSpec can change as this may later support Http Gateway too

JAHMCR commented 3 weeks ago

The new IBM Aspera for Desktop is currently expecting a desktop_spec to start a transfer, that's why we reverted this.

If we plan on supporting HTTP Gateway then I think we should rename it to something more generic.

dabrad26 commented 3 weeks ago

Yes we changed back to desktop_spec for the payload. But don't need to rename the types.