search

IBM / bamoe-docs

Documentation for IBM Business Automation Manager Open Editions (BAMOE)
https://www.ibm.com/docs/ibamoe
Apache License 2.0
9 stars 25 forks source link

Add DMN 1.5 boxed expressions documentation #108

Closed jomarko closed 6 months ago

jomarko commented 6 months ago

@kbowers-ibm thank you, I haven't applied all suggestions, because some text is a copy of the text from the editor ui. I think if we want to address remaining points, we should update also the editor ui. what do you think?

image

jomarko commented 6 months ago

@kbowers-ibm @ljmotta @danielzhe hi, after a look on the PR, I decided to add a piece of filter documentation using the item reserved keyword. This requires review of one more PR as I would like to have available source code for the documentation readers.

Would you mind to take one more look on #108 and PR?

LightGuard commented 6 months ago

Please let me know when we all feel good to merge.

danielzhe commented 6 months ago

@kbowers-ibm thank you, I haven't applied all suggestions, because some text is a copy of the text from the editor ui. I think if we want to address remaining points, we should update also the editor ui. what do you think?

The text in UI was copied from the DMN documentation, but it's up to you to change it or not.

LightGuard commented 6 months ago

Any other changes expected, or should we merge?

jomarko commented 6 months ago

@LightGuard we need to finish https://github.com/bamoe/bamoe-docs-source-code-examples/pull/4 and merge just before merging #108.

jomarko commented 6 months ago

@LightGuard hi, the related PR was merged. I think We are fine to merge #108 now.