search

IBM / bamoe-docs

Documentation for IBM Business Automation Manager Open Editions (BAMOE)
https://www.ibm.com/docs/ibamoe
Apache License 2.0
9 stars 25 forks source link

Update cors-proxy env variable name #110

Closed ljmotta closed 5 months ago

thiagoelg commented 5 months ago

I believe more places need to be changed, basically everywhere that says Git CORS Proxy in some form should be changed.

The image URL (https://quay.io/repository/bamoe/git-cors-proxy), some deploy vars (export APP_NAME_GIT_CORS_PROXY=bamoe-git-cors-proxy), etc, all need updates.

What I don't know is if we change these values and names, will it reflect on the 9.0.x docs as well? (it shouldn't! 9.0.x still uses Git CORS Proxy and should stay that way.) @LightGuard help? :grimacing:

ljmotta commented 5 months ago

@kbowers-ibm I've opened two PRs, one for main and another for 9.1.x branch. I'm not sure, should we left main outdated?

LightGuard commented 5 months ago

Once we release, I'll merge 9.1.x back to main so it is current. If the 9.1.x PR contains the same info, let's close this one.

kbowers-ibm commented 5 months ago

9.0.x uses KIE_SANDBOX_GIT_CORS_PROXY_URL 9.1 uses KIE_SANDBOX_CORS_PROXY_URL So this shouldn't be merged to the 9.0.1 docs

ljmotta commented 5 months ago

Closing this PR as the main will be updated with the 9.1.x branch