search

IBM / cics-bundle-gradle

The plugin to build and deploy CICS bundles in a Gradle build.
Eclipse Public License 2.0
7 stars 20 forks source link

Added validation around cicsplex and region for SMSS support #102

Closed ledina closed 2 years ago

sophiegreen commented 2 years ago

Wondering if this logic should be in BundleDeployHelper in cics-bundle-common so that it's covered for both Maven and Gradle?

ledina commented 2 years ago

Wondering if this logic should be in BundleDeployHelper in cics-bundle-common so that it's covered for both Maven and Gradle?

All the rest of the validation and corresponding testing is currently in the separate repos, so I thought it made sense to keep it consistent.

sophiegreen commented 2 years ago

Yep you're right actually! Although I also just found this pull request where we chose to move the validation of cicsplex and region into the server.... https://github.com/IBM/cics-bundle-maven/pull/161/files

ledina commented 2 years ago

Yes that is right, and that is because we don't know if it will be a plex or SMSS region, hence we let the server deal with that side of things, but we know we need either both or none of them to be specified, so we are choosing to report that early on.

sophiegreen commented 2 years ago

That makes sense, I think this looks good then. And we'll need the same added to the maven plugin, because it doesn't look like we're validating it there either.

ledina commented 2 years ago

Yep, maven is next!