search

IBM / cics-bundle-gradle

The plugin to build and deploy CICS bundles in a Gradle build.
Eclipse Public License 2.0
7 stars 20 forks source link

Assumption "project.version is String" leads to incompatibilities with other plugins #111

Closed vertigolo closed 2 years ago

vertigolo commented 2 years ago

Because it is assumed, that the project.version ist always a String, this plugin is incompatible with semantic release-plugins (e.g. https://github.com/tschulte/gradle-semantic-release-plugin): https://github.com/IBM/cics-bundle-gradle/blob/a27c3c84571fc9905fc9e067d143ddbb1ef9cdee/src/main/kotlin/com/ibm/cics/cbgp/BuildBundleTask.kt#L113

In the gradle documentation it is stated, that project.version should always be used with toString(): https://docs.gradle.org/current/dsl/org.gradle.api.Project.html#org.gradle.api.Project:version

In the gradle javadoc, getVersion() also returns an Object. It can not be assumed, that the version is always a String: https://docs.gradle.org/current/javadoc/org/gradle/api/Project.html#getVersion

stewartfrancis commented 2 years ago

Thanks for the bug report and the diagnosis. I'll work on putting together a fix

tom-foyle commented 2 years ago

Hi @AlinaDev. I've delivered a fix to address this. It is available in the latest development SNAPSHOT build if you want to try it out. Thanks again.

ind1go commented 2 years ago

This fix is now live in release 1.0.3.