IBM / cics-bundle-gradle

The plugin to build and deploy CICS bundles in a Gradle build.
Eclipse Public License 2.0
7 stars 20 forks source link

Give warning when no configuration parameter provided on a project dependency #54

Closed tom-foyle closed 4 years ago

tom-foyle commented 4 years ago

E.g. If user sets: cicsBundle project(path: ':path-to-project') instead of: cicsBundle project(path: ':path-to-project', configuration: 'archives') then the bundle part will not be included properly. We could detect this and give a warning.

tom-foyle commented 4 years ago

I don't think we should do anything for this. I can imagine that advanced users could legitimately have a set up where they need to depend on a project but not using the archives configuration, so I don't really want to put in a warning that might not always be valid.

Also, the readme says very clearly to use archives, and the error that you get if you don't makes it fairly clear that something is wrong with your dependency, as it will try to process it as a jar rather than a war, so I think people will be able to figure it out.