Closed tom-foyle closed 4 months ago
I'll use bundle-war
below to mean all the bundle-war
, bundle-ear
, etc goals.
I think the thing here is that the bundle-war
goal default to it being cics-bundle
, but the deploy
goal doesn't default to that because it could be being used to deploy a bundle created by either a bundle-war
goal (where classifier will be cics-bundle
or another classifier as specified) or a build
goal (where there will be no classifier, at least not without explicitly setting it).
I think this will need to be a documentation fix and logging fix - not sure I can see a fix that makes it 'just work' for all combinations. Perhaps it's possible to work out which goals have run ahead of the deploy
goal? @stewartfrancis
However, we could do the following:
<classifier>
configuration option to select the bundle, in the case where you're deploying a bundle-war
-built bundle.deploy
goal, print out the file that we're deploying. This'll make it more obvious when it ends .war
instead of .zip
.Any other ideas?
Would definitely be good to fix it though because I fall over it every time I create a new project! 😆
In the scenarios where we create a CICS bundle from an existing project, using the
bundle-osgi
/bundle-war
/bundle-ear
/bundle-eba
goals, theclassifier
attribute claims to be optional with a default value ofcics-bundle
, but omitting it frompom.xml
results in a deployment failure with the error message:Also, the comment in the samples makes it sound like the
cics-bundle
value is somehow significant to the packaging method, whereas I think it's actually just an arbitrary string which is appended to the zip filename?Relevant doc pages: https://github.com/IBM/cics-bundle-maven#create-a-cics-bundle-from-an-existing-java-module-using-cics-bundle-maven-plugin https://ibm.github.io/cics-bundle-maven/bundle-war-mojo.html#classifier