search

IBM / cics-bundle-maven

The plugin to build and deploy CICS bundles in a Maven build.
https://ibm.github.io/cics-bundle-maven/plugin-info.html
Eclipse Public License 2.0
18 stars 25 forks source link

Position of defaultjvmserver parameter is confusing. #230

Open davenice opened 6 months ago

davenice commented 6 months ago

If you're packaging an existing WAR as a bundle by extending the config, you specify the defaultjvmserver within the execution config.

If you create a separate module for the CICS bundle, you specify the defaultjvmserver outside the execution config.

This is confusing and has caught new users out several times.

davenice commented 6 months ago

Also the JVM server is set by default to MYJVMS in https://github.com/IBM/cics-bundle-maven/blob/b29130db72300135edb9dfa13d8dbaef68ae276b/cics-bundle-maven-plugin/src/main/java/com/ibm/cics/cbmp/AbstractAutoConfigureBundlePublisherMojo.java#L40

In #138 it looked like decided to stop providing a default JVM server if the user didn't specify one, because anything we supply is unlikely to be useful. However we didn't make this change in the code.

I think the behaviour needs a bit of investigating to propose the correct fix. If you configure your individual Java projects (war/ear etc) with a jvmserver parameter, I guess we shouldn't give an error about the JVM server being missing.