search

IBM / cis-integration

The goal of this project is to automate CIS integration for IBM Cloud application platforms. We will produce a command-line tool that customers can use to simplify this process.
Apache License 2.0
3 stars 0 forks source link

Making the certificate manager ordering optional, as well as adding Edge Certificate ordering to IKS #30

Closed Pseusco closed 3 years ago

Pseusco commented 3 years ago

Since we need to order an Edge Certificate for IKS as well as Code Engine, I moved certcreate.py and delete_certs.py to the common folder.

iks.py now orders an edge certificate and can delete it with the delete option.

iks.py now also asks the user if they want to create a new secret before ordering a TLS certificate in the certificate manager.

Pseusco commented 3 years ago

I added more to the terraform implementation. The ingress creation was also not working before and I attempted to fix it.

akuljos commented 3 years ago

I think the variable stuff in root_terraform is almost there; we might just need default values for all of the variables that don't currently have them though, cause if we try to make a ce module for instance, the workspace will error out and say that cluster_id, ingress, and cert_name don't have assigned values.

Chris-Springstead commented 3 years ago

Looks good. Maybe wait until we merge the testing branch into master before we merge this one since I think this has the latest updates to iks.py.

Pseusco commented 3 years ago

Been changing a bunch of the stuff in the terraform. Creating a secret in iks after ordering a certificate in the certificate manager was not working and I tried to fix it. Not 100% sure it's working because I got rate-limited in both CIS instances