IBM / clai

Command Line Artificial Intelligence or CLAI is an open-sourced project from IBM Research aimed to bring the power of AI to the command line interface.
https://clai-home.mybluemix.net/
MIT License
478 stars 75 forks source link

Highlighted user and pass #44

Closed madhavanpallan closed 4 years ago

madhavanpallan commented 4 years ago

:pushpin: References

:tophat: What is the goal?

a) The goal here is better visibility of username and password of the server deployed using docker. b) Documentation of control flags for build docker image in different versions of Ubuntu.

:memo: How is it being implemented?

a) -e option of echo enables the parsing of the escape sequence. Here “\e[32m” sequence changes the colour of text to green while the “\e[0m” sequence removes all the colour and formatting at the end(Updated) b) keeping the value of flags empty in docker build script completes the process without error for default docker build in kernel version 4.4.0-75-generic (Trusty Tahr/ Ubuntu 14.04 LTS). While the rest remains the usual for ubuntu 16.04 and above. We have added descriptive explanations as control flags in Readme under the container build section.

:tv: Screenshot or gif showing the result.

Screenshot

Introduce here a gif or picture about the work

:boom: How can it be tested?

It can be tested by running the command sudo ./RunDockerImage.sh for the same.

TathagataChakraborti commented 4 years ago

@madhavanpallan this PR should be directed to master not iss9 on the main repo.

madhavanpallan commented 4 years ago

@TathagataChakraborti: Sure, Now the PR has been directed to the main repo.

TathagataChakraborti commented 4 years ago

Doesn't seem to work on my Mac?

Screen Shot 2020-03-25 at 9 01 10 AM
sarathsreedharan commented 4 years ago

I think that fix only works for sh and not for Bash (which is what gets invoked when you run ./RunDockerImage.sh)

Screenshot from 2020-03-25 17:32:24

vs

Screenshot from 2020-03-25 17:34:14

Also if you are going down this route, you might want to disable to color at the end of the echo.