IBM / cloudant-node-sdk

Cloudant SDK for Node.js
Apache License 2.0
28 stars 13 forks source link

Request to remove "package-lock.json" to allow consumers to install the latest security fixes for all transitive dependencies based on semvers defined in "package.json" #1523

Closed mpawlow closed 4 months ago

mpawlow commented 4 months ago

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

ricellis commented 4 months ago

We already do not include the package-lock.json in our published module so there is nothing to remove. The source package-lock.json should have no impact on downstream consumers.

We do pin dependency versions in our package.json to the versions that we have tested and can support. We resolve CVEs and publish new versons as soon as possible.

It is also possible to override dependencies in your own project's manifests if you like. Although at this point in time for this particular case there are no new versions available to use. If ibm-cloud-sdk-core releases a new version without the expect dependency then rest asssured we will update and test soon after.

mpawlow commented 4 months ago

Confirmed.

image

Thanks for the quick response.

ricellis commented 4 months ago

Now the micromatch and braces modules have had updates released running npm update should resolve this problem. New releases of node-sdk-core and cloudant-node-sdk are not required because the fixed transitive packages are within the existing acceptable dependency version ranges.