search

IBM / cloudpak-gitops

Deployment of IBM Cloud Paks using ArgoCD / Red Hat GitOps operator.
Apache License 2.0
22 stars 23 forks source link

fix: Cloud Pak for Integration module selection needs to deal with booleans as strings #276

Closed nastacio closed 1 year ago

nastacio commented 1 year ago

Describe the bug

The cp4i-app application has a configuration array called "modules", containing the following values: "apic", "mq", and "client".

These properties are defined as boolean values, which tend to have dedicated type handling in some places, like yaml files, but not in others, like --helm-set-string parameters in the argocd CLI, where there is no distinction between strings and booleans.

Though conceptually not ideal, it is best to treat them all as strings through the entire Helm chart, so that it is possible to assign them from the argocd CLI as well.

To Reproduce Steps to reproduce the behavior:

  1. Install cp4i-app via CLI, but when it is type to invoke argocd create app cp4i-app, add the following parameter --helm-set-string modules.apic=true

Expected behavior Installation should proceed with the module "apic" (API Connect) being installed.

Screenshots Installation fails, with Argo reporting that there is a type match issue in the Helm chart.

Additional context Add any other context about the problem here.

nastacio commented 1 year ago

:tada: This issue has been resolved in version 0.29.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: