search

IBM / cloudpakforapps-workshop

A two day workshop on IBM's Cloud Pak for Application platform -- https://ibm.github.io/cloudpakforapps-workshop/
Apache License 2.0
5 stars 17 forks source link

use openshift config map and more cleanup #18

Closed stevemar closed 5 years ago

henrynash commented 5 years ago

This looks good. One minor thing is that if we do add namespace to the metadata in the deploy yaml, I think we can remove the --namespace arguments from the appsody deploy lines.

henrynash commented 5 years ago

Hmm, actually, I am not sure my last comment is correct....I just tried this out and you still need to add the --namespace flag. That seems like a bug to me (and have raised it https://github.com/appsody/appsody/issues/464). I will follow up with another PR if we can indeed remove the step of adding the namespace to the manifest.