common fyre_vm failures after refactoring

[stevenschader]

Describe the bug fyre vm refactoring problems.

Example:

TASK [instana_fyrevm : include_tasks] *****************************************************************************************************************
task path: /mnt/data/git/community-automation/ansible/roles/instana_fyrevm/tasks/main.yml:3
fatal: [localhost]: FAILED! => {
  "reason": "conflicting action statements: include_role, fyre_memory\n\nThe error appears to be in '/mnt/data/git/community-automation/ansible/roles/instana_fyrevm/tasks/instana_fyrevm.yml': line 3, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Create FyreVM with appropriate spec\n ^ here\n"

[stevenschader]

I'm getting this error once the fyre_vm yaml is corrected:

TASK [fyrevm_provision : Ensure SSH Key] **************************************************************************************************************
task path: /mnt/data/git/community-automation/ansible/roles/fyrevm_provision/tasks/fyrevm_provision.yml:14
fatal: [localhost]: FAILED! => {
    "changed": false, 
    "invocation": {
        "module_args": {
            "path": "/home/nest/.ssh/id_rsa", 
            "regenerate": "never"
        }
    }, 
    "msg": "Unsupported parameters for (openssh_keypair) module: regenerate Supported parameters include: attributes, backup, comment, content, delimiter, directory_mode, follow, force, group, mode, owner, path, regexp, remote_src, selevel, serole, setype, seuser, size, src, state, type, unsafe_writes"
}

https://github.com/IBM/community-automation/blob/a05b0ddf182dc286fca2d81ded451e42183212bf/ansible/roles/fyrevm_provision/tasks/fyrevm_provision.yml#L17

• name: Ensure SSH Key openssh_keypair: path: "{{ lookup('env','HOME')}}/.ssh/id_rsa" regenerate: never

  If I comment out the regenerate it runs ok...
  My ansible --version is

  ansible 2.9.24 config file = /etc/ansible/ansible.cfg configured module search path = [u'/home/nest/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules'] ansible python module location = /usr/lib/python2.7/dist-packages/ansible executable location = /usr/bin/ansible python version = 2.7.17 (default, Feb 27 2021, 15:10:58) [GCC 7.5.0]

If I use the community-automation docker image I don't get this error...