When attempting to remove a tags: ["tag1","tag2"] property from a Trigger, or an events: ["push"] property from a SCM Trigger, the removal would fail and the tags/events left in place in the trigger. This was because of the omitempty tag included for those proeprties in the generated Go SDK. By adding the x-sdk-go-serialize-empty annotation for the Tags and Events properties in the openAPI spec, the omitempty is excluded for these properties and the issue is fixed
PR Checklist
Please make sure that your PR fulfills the following requirements:
Signed-off-by: Brian Gleeson brian.gleeson@ie.ibm.com
PR summary
Related issue: https://github.ibm.com/one-pipeline/adoption-issues/issues/1110
When attempting to remove a
tags: ["tag1","tag2"]
property from a Trigger, or anevents: ["push"]
property from a SCM Trigger, the removal would fail and the tags/events left in place in the trigger. This was because of theomitempty
tag included for those proeprties in the generated Go SDK. By adding thex-sdk-go-serialize-empty
annotation for the Tags and Events properties in the openAPI spec, theomitempty
is excluded for these properties and the issue is fixedPR Checklist
Please make sure that your PR fulfills the following requirements:
PR Type
Does this PR introduce a breaking change?
Other information