IBM / continuous-delivery-go-sdk

Go client library for IBM Cloud Continuous Delivery
Apache License 2.0
4 stars 6 forks source link

fix(tekton): fix for empty tags and events #43

Closed briangleeson closed 1 year ago

briangleeson commented 1 year ago

Signed-off-by: Brian Gleeson brian.gleeson@ie.ibm.com

PR summary

Related issue: https://github.ibm.com/one-pipeline/adoption-issues/issues/1110

When attempting to remove a tags: ["tag1","tag2"] property from a Trigger, or an events: ["push"] property from a SCM Trigger, the removal would fail and the tags/events left in place in the trigger. This was because of the omitempty tag included for those proeprties in the generated Go SDK. By adding the x-sdk-go-serialize-empty annotation for the Tags and Events properties in the openAPI spec, the omitempty is excluded for these properties and the issue is fixed

PR Checklist

Please make sure that your PR fulfills the following requirements:

PR Type

Does this PR introduce a breaking change?

Other information

briangleeson commented 1 year ago

:tada: This PR is included in version 1.0.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: