search

IBM / core-dump-handler

Save core dumps from a Kubernetes Service or RedHat OpenShift to an S3 protocol compatible object store
https://ibm.github.io/core-dump-handler/
MIT License
131 stars 40 forks source link

Use error logger in timeout condition #113

Closed timbuchwaldt closed 1 year ago

No9 commented 1 year ago

You've probably realized error! goes to std.err not std.out. Don't forget to sign it so the DCO passes. I want to get my patch to log4rs in the next release of CDH too https://github.com/estk/log4rs/commit/1b988edd87c47d1c85afe4af8dee0aff38254456 so I'll publish this as soon as you're ready.

timbuchwaldt commented 1 year ago

Sorry about the dealy, there you go :)

No9 commented 1 year ago

Hey @timbuchwaldt The test for timeout is failing now. Can you take a look when you have a minute.

No9 commented 1 year ago

Hey @timbuchwaldt January house keeping :) Is this still WIP or should we close it?

No9 commented 1 year ago

Hey @timbuchwaldt - Thanks for coming back to this. Do you want to land this now it's passing?