search

IBM / core-dump-handler

Save core dumps from a Kubernetes Service or RedHat OpenShift to an S3 protocol compatible object store
https://ibm.github.io/core-dump-handler/
MIT License
131 stars 40 forks source link

Add environment variables to Chart for Timeout and No Compression #116

Closed No9 closed 1 year ago

No9 commented 1 year ago

@timbuchwaldt I've moved the setting of the timeout out of the composer arguments and into the chart so it's setup as an environment variable called TIMEOUT. https://github.com/IBM/core-dump-handler/commit/867b4a797a9517aefc062839be48cf97214446c6#diff-41993b17674b907eda9d68b0aabdb0fe6cca65177bc94b74cba88ffc23932dc2R30

@stonemaster The disable compression -D has also been removed and added an environment variable called COMPRESSION to the composer config https://github.com/IBM/core-dump-handler/commit/867b4a797a9517aefc062839be48cf97214446c6#diff-41993b17674b907eda9d68b0aabdb0fe6cca65177bc94b74cba88ffc23932dc2R31

The image is building here: https://quay.io/repository/icdh/core-dump-handler/build/b50f285f-8120-4a84-ad7e-beb3358afe97

Once that is compete you should be able to checkout the schema-update branch and validate.

Let me know if you have any comments suggested changes.

Thanks

[Edit] Baseline integration tests pass.

timbuchwaldt commented 1 year ago

Hey! Sorry for the delay, was away on vacation and a business trip. Looks great, I'll have a look when I can roll it out to test!

timbuchwaldt commented 1 year ago

Sorry for the long delay again, this was some turbulent time :D When trying to access the built image it asks for login. I assume that's something IBM-internal?

No9 commented 1 year ago

Do you mean that when you are running docker pull quay.io/icdh/core-dump-handler:schema-updates you are now getting challenged for a password? I didn't hear of a change on policy on quay.

timbuchwaldt commented 1 year ago

Oh wow never mind, I mindlessly clicked the link and was prompted for a login M)

No9 commented 1 year ago

Cool - You should just(tm) be able to check out the branch apply your settings and run it

timbuchwaldt commented 1 year ago

It’s running on one of our clusters now.Sent from my iPhoneOn 25. Nov 2022, at 18:58, Anton Whalley @.***> wrote: Cool - You should just(tm) be able to check out the branch apply your settings and run it

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

No9 commented 1 year ago

Great stuff - I'll take that as a go

No9 commented 1 year ago

@timbuchwaldt Can you give an ok with the review button when you have a minute please.