IBM / core-dump-handler

Save core dumps from a Kubernetes Service or RedHat OpenShift to an S3 protocol compatible object store
https://ibm.github.io/core-dump-handler/
MIT License
131 stars 40 forks source link

pullSecrets is not used inside daemonset.yaml #129

Closed rohsaini closed 1 year ago

rohsaini commented 1 year ago

In charts, pullSecrets is present in values.yaml but is not being used inside templates/daemonset.yaml.

No9 commented 1 year ago

Hi @rohsaini Happy to take a pull request for this if you require it.

rohsaini commented 1 year ago

Hi @No9 Thanks. Yes, this is required by me. Attaching my local fix for your reference. fix_patch.docx

No9 commented 1 year ago

Hi @rohsaini Would you mind opening a PR with that and I can pull it in as we have a gated review process. Also please remember to sign the commit for the DCO Thanks

rohsaini commented 1 year ago

Sure. Raised https://github.com/IBM/core-dump-handler/pull/130

Thanks.

No9 commented 1 year ago

Thanks again for the PR - I'll release in the next few days.

rohsaini commented 1 year ago

Thanks @No9