search

IBM / core-dump-handler

Save core dumps from a Kubernetes Service or RedHat OpenShift to an S3 protocol compatible object store
https://ibm.github.io/core-dump-handler/
MIT License
131 stars 40 forks source link

Chart value "composer.logLength" doesn't affect. #139

Closed oniku-2929 closed 1 year ago

oniku-2929 commented 1 year ago

Hi @No9.

I found that the chart value composer.logLength doesn't affect to the composer's actual setting value LOG_LENGTH. Then it's just used the default value 500 even though I specify it like this.

helm install core-dump-handler . --set composer.logLength=10

Because core-dump-agent doesn't read the environment variable "COMP_LOG_LENGTH" passed from daemonset.yaml.

No9 commented 1 year ago

Thanks very much for this @oniku-2929 good catch.

If you can sign the commit as per https://github.com/IBM/core-dump-handler/pull/139/checks?check_run_id=12098075677 I can land this in.

oniku-2929 commented 1 year ago

@No9 Thank you for your checking. I signed the commit.