search

IBM / core-dump-handler

Save core dumps from a Kubernetes Service or RedHat OpenShift to an S3 protocol compatible object store
https://ibm.github.io/core-dump-handler/
MIT License
136 stars 40 forks source link

Capture proc data to be able to generate minidump #156

Closed swermin closed 2 months ago

swermin commented 8 months ago

Let me start by saying that this project has helped me bring core dump related stuff out of process and I love it! The current setup we have is to generate a minidump from a core dump, which we use breakpads core2md

To be able to configure a proper minidump, some data from the /proc/$pid/ folder is needed. I have forked this project and added the changes needed for us to be able to support this flow. What it does is that it checks for a flag to see if needs to include proc info, if does then these steps are taken:

The process is repeated for every container in that pod.

I would love to contribute back this change into this project, is that something you all would be interested in having?

No9 commented 8 months ago

That sounds like an excellent feature - thanks for offering to share it back. I need to resolve a side issue with the build system as we have disabled external actions but please open a PR when you are ready and we can start to land it.

swermin commented 8 months ago

The change is split in two repos, one for the libcrio and one for this repo. I've created a PR for the libcrio part, here is the link: https://github.com/IBM/core-dump-handler/issues/156#issuecomment-1974139747

Second PR, for the actual core dump handler, is coming soon

No9 commented 8 months ago

Thanks - I've merged the PR with some additional house keeping around the workflows and released into crates.io as well as tagged in the repo - https://github.com/No9/libcrio/releases/tag/v2.1.0

swermin commented 7 months ago

Sorry for this taking more time than necessary. I had some trouble getting the whole feature tested well enough before I wanted to start a PR. I think I got a clean enough solution, so I have created this PR: https://github.com/IBM/core-dump-handler/pull/157

Please let me know if there is something that you want changed and I'll do that!