IBM / core-dump-handler

Save core dumps from a Kubernetes Service or RedHat OpenShift to an S3 protocol compatible object store
https://ibm.github.io/core-dump-handler/
MIT License
131 stars 40 forks source link

Add service account token secret #160

Closed usimd closed 4 months ago

usimd commented 4 months ago

Adds a new secret to be compatible with EKS >= 1.24 (see https://aws.github.io/aws-eks-best-practices/security/docs/iam/).

This closes https://github.com/IBM/core-dump-handler/issues/143 and closes https://github.com/IBM/core-dump-handler/issues/140.

Open design questions:

Let me know what you think :smiley:

No9 commented 4 months ago

@usimd Thank you very much for this work.

usimd commented 4 months ago

Thank you for sharing this work, @No9! Much appreciated :+1:

Would it be possible to create a new release with this PR in place? Or are there other changes you're waiting for?

No9 commented 4 months ago

Yes I want to try and land this before the next release https://github.com/IBM/core-dump-handler/pull/157