search

IBM / core-dump-handler

Save core dumps from a Kubernetes Service or RedHat OpenShift to an S3 protocol compatible object store
https://ibm.github.io/core-dump-handler/
MIT License
131 stars 40 forks source link

Agent Mocks #52

Closed No9 closed 2 years ago

No9 commented 2 years ago

Currently the agent requires root access to make the sysctl calls this makes it hard to develop with locally and very difficult to test in CI environments. Logging this issue to investigate creating a mock sysctl similar to the crictl in composer that could be used to validate most of the agent functionality without having to run the integration test.

No9 commented 2 years ago

Mock sysctl created as part of this commit https://github.com/IBM/core-dump-handler/commit/ae77f61ad4c41dd5ca546fc733c1d3322245bbdd

No9 commented 2 years ago

On review the agent will need a significant refactor in order to move tests from integration into units. Given the split between the initialization and running pod also needs to be implemented I'm going to close this and come out with a plan for release 8.0.0.