Closed razielgn closed 2 years ago
Thanks very much for this contribution.
Happy to take the code but would you mind putting some info on the configuration into the chart readme below the eksctl section.
https://github.com/IBM/core-dump-handler/blob/main/charts/core-dump-handler/README.md#eks-setup-for-gitops-pipelines-eksctl-or-similar
Also should there be an example values.yaml
for it as well?
Something like https://github.com/IBM/core-dump-handler/blob/main/charts/core-dump-handler/values.aws.yaml
and call it values.aws.sts.yaml
Sure, I've added a commit with more documentation and examples.
Great thanks for the update - I'll bundle and push a release towards the end of this week.
Awesome, thank you!
merged and released in 8.4.0 Thanks again for this @razielgn
Hello, this patch makes it possible to use the preferred way to authenticate pods with AWS STS (see here). tl;dr without setting a keypair, but instead loading tokens from a mounted file handled by an admission controller.
I've tested it on our EKS deployment before submitting this PR.