search

IBM / cp4i-deployment-samples

Samples for deploying Cloud Pak for Integration capabilities in a pipeline
Apache License 2.0
22 stars 94 forks source link

Feat: Added support for large APIC names #319

Closed jeesonjohnson closed 1 year ago

jeesonjohnson commented 1 year ago

Currently, the APIC configure script does not work well when the length of the release name is greater than 10 characters. This is because APIC restricts the name to something smaller than 10 characters. For instance, the release name cp4i-apic-apic gets concatenated into cp4i-apic- followed by a random hash. This results in this script not functioning, since it does not account for the concatenation.

Example if release name = ademo: Image 28-03-2023 at 11 25

Example if release name is = cp4i-apic-apic: Image 28-03-2023 at 11 27

As is evident above, the name of the routes change depending on the length. This PR therefore changes the regex to take this into account.

jeesonjohnson commented 1 year ago

Testing with short APIC names, e.g: ademo: E02B2878-66AA-4A97-9251-033B32CE08D0

Testing with long APIC names, e.g: cp4i-apic-apic: Image 28-03-2023 at 11 34

With both types, the scripts seem to be functioning as intended.