search

IBM / cp4waiops-gitops

Manage Your IBM Cloud Pak for Watson AIOps With GitOps
https://ibm.github.io/cp4waiops-gitops/docs/
Apache License 2.0
11 stars 26 forks source link

Correct the default value of cp4waiops.version param in all-in-one template #210

Closed morningspace closed 1 year ago

morningspace commented 1 year ago

The all-in-one template using v3.3 as the default value for cp4waiops.version param even it's on 3.4 branch. See below UI:

image

Also, the _helpers.tpl in all-in-one template needs to be corrected since we do not mix multiple per-release templates on the same branch now. e.g.: there is no config/3.2/ai-manager any more.

{{- define "cp4waiops.aimanager.configPath" -}}
  {{- if eq .Values.cp4waiops.version "v3.2" }}
  {{- printf "config/3.2/ai-manager" -}}
  {{- else if eq .Values.cp4waiops.version "v3.3" }}
  {{- printf "config/cp4waiops/install-aimgr" -}}
  {{- else if eq .Values.cp4waiops.version "v3.4" }}
  {{- printf "config/cp4waiops/install-aimgr" -}}
  {{- else }}
  {{- fail "The CP4WAIOps all in one chart only supports release v3.2, v3.3, v3.4." }}
  {{- end }}
{{- end -}}
huang-cn commented 1 year ago

@morningspace all-in-one version and mixed version fixed in this PR https://github.com/IBM/cp4waiops-gitops/pull/214. Closing this issue.