search

IBM / css-gridish

Automatically build your grid design’s CSS Grid code, CSS Flexbox fallback code, Sketch artboards, and Chrome extension.
https://ibm.github.io/css-gridish/
Other
2.25k stars 113 forks source link

No legacy class for last breakpoint #47

Open j1mie opened 6 years ago

j1mie commented 6 years ago

Hi @seejamescode

Wondering why we don't create a class for the last breakpoint?

Thanks!

https://github.com/IBM/css-gridish/blob/c5f16a541df485fa833f8f50299bd6a3f290a142/src/scss/_mixins.scss#L43

seejamescode commented 6 years ago

Last breakpoint is really the "max-width". With the IBM grid design specs, we weren’t really meaning for a design to rearrange content at that max-width. However, reconfiguring the config file to reflect this more would be a good v3 improvement.

j1mie commented 6 years ago

Ah, I get you.

I think clarification would help here - coming from other popular grid systems (where max-width and last breakpoint aren't always the same value) this could confuse people a little. Was looking at the carbon example and wondering why there were only classes for one breakpoint.

Thanks for the quick response.

seejamescode commented 6 years ago

I don’t think the README documents classes for that last breakpoint, but adding a line about it here would be helpful.