search

IBM / data-prep-kit

Open source project for data preparation of LLM application builders
https://ibm.github.io/data-prep-kit/
Apache License 2.0
171 stars 111 forks source link

Build libs for kfp v1 and v2 in the release. #335

Closed Mohammad-nassar10 closed 3 months ago

Mohammad-nassar10 commented 3 months ago

Why are these changes needed?

Add building and publishing the two kfp images of kfp v1 and v2 when creating a new release.

Related issue number (if any).

roytman commented 3 months ago

Holding off merge until we closed on questions I've raised elswhere on this PR.

see my answer.

daw3rd commented 3 months ago

@Mohammad-nassar10 - @roytman and I spoke and agreed that

  1. the publishing of both kfp versions should be handled inside kfp/Makefile - transparently to the top level Makefile
  2. We will remove/disable the actual make build publish in the release script and handle that either manually in the new branch or with a git action somehow.

As a result I think this PR can be closed. Another one #338 is started to address those (and your fixes made here)