IBM / data-prep-kit

Open source project for data preparation of LLM application builders
https://ibm.github.io/data-prep-kit/
Apache License 2.0
171 stars 111 forks source link

[Bug] release-branch.sh script needs to not commit and push to the main branch. #361

Closed daw3rd closed 2 months ago

daw3rd commented 3 months ago

Search before asking

Component

CI/CD

What happened + What you expected to happen

The scripts/release-branch.sh script currently modifies and commits directly to the main/dev branch and pushes it. This should instead create a new branch, from which a PR is then requested back into main/dev.

This was identified as a problem when some transforms (see #355) did not properly implement set-versions and so the versions were out of sync, but this was pushed into main.

Reproduction script

d

Anything else

d

OS

Other

Python

Other

Are you willing to submit a PR?

daw3rd commented 2 months ago

Fixed in pr #393