IBM / data-prep-kit

Open source project for data preparation of LLM application builders
https://ibm.github.io/data-prep-kit/
Apache License 2.0
307 stars 134 forks source link

[Bug] repo_level_ordering failing kfp_ray test #676

Open daw3rd opened 1 month ago

daw3rd commented 1 month ago

Search before asking

Component

Transforms/Other

What happened + What you expected to happen

With the recent PR to properly enabled kfp workflow tests (PR #672) on transforms, we found that repo_level_ordering was not passing (see log here). To get the PR to pass, repo_level_ordering/kfp_ray/Makefile was renamed to Makefile.disable-cicd.

Reproduction script

To reproduced

cd transforms/code/repo_level_ordering/kfp_ray
git mv Makefile.disable-cicd Makefile
git commit -s -a -m "restore kfp_ray test for repo_level_ordering"
git push

Make a PR and watch the cicd

Anything else

In case the log link expires...


 make[5]: Leaving directory '/home/runner/work/data-prep-kit/data-prep-kit/kfp/kfp_ray_components'
rm -rf data-processing-lib-ray
rm -rf data-processing-lib-python
rm -rf shared_workflow_support_lib
rm -rf workflow_support_lib
make[4]: Leaving directory '/home/runner/work/data-prep-kit/data-prep-kit/kfp/kfp_ray_components'
make[3]: Leaving directory '/home/runner/work/data-prep-kit/data-prep-kit/kfp/kfp_ray_components'
make[3]: Entering directory '/home/runner/work/data-prep-kit/data-prep-kit/kfp/kfp_ray_components'
kind load docker-image quay.io/dataprep1/data-prep-kit/kfp-data-processing:latest --name=dataprep
Image: "quay.io/dataprep1/data-prep-kit/kfp-data-processing:latest" with ID "sha256:e106bb44519fa6af000644101720ee5faa0226bd7cfe03d8b0b7b7bc3df98a48" not yet present on node "dataprep-worker", loading...
Image: "quay.io/dataprep1/data-prep-kit/kfp-data-processing:latest" with ID "sha256:e106bb44519fa6af000644101720ee5faa0226bd7cfe03d8b0b7b7bc3df98a48" not yet present on node "dataprep-control-plane", loading...
Image: "quay.io/dataprep1/data-prep-kit/kfp-data-processing:latest" with ID "sha256:e106bb44519fa6af000644101720ee5faa0226bd7cfe03d8b0b7b7bc3df98a48" not yet present on node "dataprep-worker2", loading...
make[3]: Leaving directory '/home/runner/work/data-prep-kit/data-prep-kit/kfp/kfp_ray_components'
. /home/runner/work/data-prep-kit/data-prep-kit/transforms/code/repo_level_ordering/kfp_ray/../../../..//transforms/venv/bin/activate  && python -m workflow_support.pipeline_utils.pipelines_tests_utils -c "sanity-test" -p /home/runner/work/data-prep-kit/data-prep-kit/transforms/code/repo_level_ordering/kfp_ray/repo_level_order_transform.py -e "http://localhost:8080/" 
08:00:25 WARNING - Failure to get pipeline. Number of pipelines with name repo_level_order_transform is 0
08:00:25 WARNING - Exception uploading pipeline [Errno 2] No such file or directory: '/home/runner/work/data-prep-kit/data-prep-kit/transforms/code/repo_level_ordering/kfp_ray/repo_level_order_transform.py'
make[2]: *** [/home/runner/work/data-prep-kit/data-prep-kit/transforms/code/repo_level_ordering/kfp_ray/../../../..//transforms/.make.workflows:46: .workflows.test-pipeline] Error 1
make[2]: Leaving directory '/home/runner/work/data-prep-kit/data-prep-kit/transforms/code/repo_level_ordering/kfp_ray'
make[1]: *** [Makefile:45: workflow-test] Error 2
make[1]: Leaving directory '/home/runner/work/data-prep-kit/data-prep-kit/transforms/code/repo_level_ordering/kfp_ray'
make: *** [Makefile:56: workflow-test] Error 2
make: Leaving directory '/home/runner/work/data-prep-kit/data-prep-kit/transforms/code/repo_level_ordering'

OS

Ubuntu

Python

3.10.x

Are you willing to submit a PR?