search

IBM / db2-samples

Db2 application code, configuration samples, and other examples
https://www.ibm.com/analytics/developing-with-db2
Apache License 2.0
85 stars 86 forks source link

Db2 authentication plugin using AWS Cognito #78

Open npanpaliya opened 9 months ago

npanpaliya commented 8 months ago

I'm told by Andrew and Irina that this still being reviewed and is not quite ready to go, not least of all because it contains a number of file headers which say that they are IBM confidential material, which of course would not belong here. I have been reassured by them that this was just a simple cut'n'paste error and that the contents are not actually confidential, but the PR will need to be cleaned up first anyway.

Yes, I'm correcting these and these are copy/paste errors.

npanpaliya commented 8 months ago

@kdrodger @memmertoIBM - I've corrected the copyright info in all the source files. Also addressed the other comments regarding AWS libraries/version and README update. Thank you for the review and please let me know if you've further comments.

npanpaliya commented 8 months ago

There is just one issue left to be fixed which I'm working on. It is in the src/Makefile.

npanpaliya commented 8 months ago

There is just one issue left to be fixed which I'm working on. It is in the src/Makefile.

This issue is fixed too.

@kdrodger @memmertoIBM - Request you to review this PR.

kdrodger commented 6 months ago

Is this ready to be considered for merging now @npanpaliya @memmertoIBM . It's fine if not, I just wanted to confirm. Thanks.

npanpaliya commented 1 month ago

Is this ready to be considered for merging now @npanpaliya @memmertoIBM . It's fine if not, I just wanted to confirm. Thanks.

I'm no more part of this project. Please reach out to Andrew Hilden at IBM.