search

IBM / dbb-zappbuild

zAppBuild is a generic build solution for building z/OS applications using Apache Groovy build scripts and IBM Dependency Based Build (DBB) APIs.
Apache License 2.0
42 stars 144 forks source link

Fix NPE when using dependency file #230

Closed lburgess07 closed 2 years ago

lburgess07 commented 2 years ago

This PR resolves the NPE mentioned in defect #229 . The defect was introduced in zAppBuild 2.5.0 and occurs when passing a dependency file to the build framework when using the deprecated DependencyResolver APIs.

The fix involves moving the call to retrieve the logical file until after the copySourceFiles call is made which manually sets the logical file when a dependency file is utilized.

I confirmed the fix resolved the NPE when passing a dependency file using the DependencyResolver and also confirmed user build works as expected when leveraging the new SearchPathDependencyResolver.