IBM / dbb-zappbuild

zAppBuild is a generic build solution for building z/OS applications using Apache Groovy build scripts and IBM Dependency Based Build (DBB) APIs.
Apache License 2.0
41 stars 140 forks source link

Pipeline execution not honoring File Build Rank order #259

Closed ChristopherJohns-GMCom closed 1 year ago

ChristopherJohns-GMCom commented 1 year ago

Hello,

We have found a problem that may have been happening for a while. There is a ranking system in our Environment that sorts the programs to be compiled into a logical order. Sub-programs are compiled before the calling programs for example.

To do this, there is a property named 'fileBuildRank'. This property has a build rank specification assigned to it. Here's a simple example for PL/I, but it's the same for all program languages.

pli_fileBuildRank=10 :: */plisub/.pli,20 :: */plisrc/.pli

This is supposed to sort the programs so that anything from the plisub folder is compiled before anything from the plisrc folder. What we've found is that only the first value in the property (10 :: */plisub/.pli) is being used. All values after that are being ignored. For more complicated fileBuildRank definitions, this can cause problems.

Since the first value in the property definition is being used, it seems like there may be an issue with multiple values being recognized/honored.

I tried different value separators, such as a space or semi-colon, but that didn't make a difference.

How does this function operate? Is there something in the properties file that needs to be changed? I can provide documentation for what you'd like to see.

Please let us know.

Thank You,

Chris

dennis-behm commented 1 year ago

Hi @ChristopherJohns-GMCom ,

thank you for submitting the question here.

The fileRanks in the different language scripts are following the DBB BuildProperty syntax for file properties.

Rather than specifying multiple ranks on the same property assignment, it needs to look like this:

pli_fileBuildRank=10 :: **/plisub/*.pli
pli_fileBuildRank=20 :: **/plisrc/*.pli

Please let us know, if this is solving your problem.

Dennis

ChristopherJohns-GMCom commented 1 year ago

Hi Dennis,

That fixed the issue. Thank You for your quick response. It is greatly appreciated!

Chris

ChristopherJohns-GMCom commented 1 year ago

Apologies. I used "Close with Comment" in the drop down, but the issue still shows as "Open". How do I close this issue?

Thanks,

Chris

ChristopherJohns-GMCom commented 1 year ago

Nevermind. I figured it out.