Do not consider an only (Git) moved file as a modified file

[FALLAI-Denis]

Hi,

We have a problem with files moved inside a Git repository without being modified: nothing distinguishes them (for Git) from simply renamed files, because in both cases they are seen with a R100 Git action.

However, the files that have only been moved have not really been modified, but just moved, and this does not necessarily justify (re)building them.

zAppbuild should distinguish the two cases or R100 Git action:

• file only moved: not necessarily to (re)build, since files are most often copied to PDS for building, and therefore are not dependent on their location in the Git Repository.
• file renamed (and possibly moved): a priori to be built because it is no longer the same file, because of the name change; in fact in this case it should be considered that we have a creation and a deletion of file, and not a renaming.

For this, in case of R100 action, it would also be necessary to test the name of the file without the path of the folder which contains it to distinguish the two cases.

Lists powered by GitUtilities.groovy / getChangedFiles should also be handled differently:

• R100 on only moved file (same file name): feed a movedFiles list (file is not "changed")
• R100 on renamed file (new file name) without modification, (possibly also moved): feed the changedFiles (new name) and deletedFiles (old name) lists
• R not 100 on moved (same file name) and modified file : feed movedFiles and changedFiles list
• R not 100 on renamed (new file name) and modified file (possibly also moved) : feed the changedFiles (new name) and deletedFiles (old name) lists

In this case the renamedFiles list no longer exists... unless we also want to know which files are only renamed (and possibly moved). But in this case why not also manage the list of purely created files (Git action A) because there could be specific actions to do in case of pure creation.

If we want to be complete and cover all cases, we would need the lists:

• createdFiles: new files and actually renamed file (new name)
• modifiedFiles: existing files modified, possibly moved (R not 100 and same file name)
• deletedFiles: deleted files or actually renamed files (old name)
• movedFiles: existing files only moved (same file name) and without modification

There may be specific actions in case of creation and in case of deletion of files, and it seems interesting to us to identify these cases.

The changedFiles list would actually be the merging of the createdFiles + modifiedFiles lists.

[FALLAI-Denis]

Hi,

Problem stil present...

A "simply moved file" does'nt need to be built, (no change on source file, no change on binary outputs), but Collection needs to be updated to register is new path (and rescanned to find its dependencies...).

We have to modify:

• GitUtilities.groovy to generate a "newNameFiles" list : getChangedFiles and getCurrentChangedFiles functions
• ImpactUtilities.groovy to update Collection with "newNameFiles" list : UpdateCollection function

And all refernces to these functions...