search

IBM / dbb-zappbuild

zAppBuild is a generic build solution for building z/OS applications using Apache Groovy build scripts and IBM Dependency Based Build (DBB) APIs.
Apache License 2.0
40 stars 124 forks source link

Harden the zAppBuild test framework #361

Closed dennis-behm closed 1 year ago

dennis-behm commented 1 year ago

To perform test for impact build scenarios, the test framework is copying a changed version from the test/applications directory and commits this change. These files cannot be reused for additional impact build scenarios, because they don't represent a change to the file.

https://github.com/IBM/dbb-zappbuild/blob/85e0df0ed7d693457473303ba5873524bb5f7797/test/testScripts/impactBuild.groovy#LL70C3-L70C16

Rather than copying and committing the test framework should append a blank line, like introduced in this script with the recent zAppBuild release:

https://github.com/IBM/dbb-zappbuild/blob/85e0df0ed7d693457473303ba5873524bb5f7797/test/testScripts/impactBuild_preview.groovy#L123-L134

This should be turned into a utility method and all scripts requiring a change of files should be accordingly adopting this.

dennis-behm commented 1 year ago

Delivered with zAppBuild Release V3.3.0