IBM / dbb-zappbuild

zAppBuild is a generic build solution for building z/OS applications using Apache Groovy build scripts and IBM Dependency Based Build (DBB) APIs.
Apache License 2.0
40 stars 124 forks source link

Refactor loading application-conf directory #399

Closed dennis-behm closed 10 months ago

dennis-behm commented 11 months ago

zAppBuild is hard-coding how the application-conf directory is picked up:

https://github.com/IBM/dbb-zappbuild/blob/9beaa5847a20dae2a8a1cbffc44fe6652e081222/build.groovy#L363-L373

There are a couple of weaknesses with this code in this area:

The applicationConfRootDir property is overwriting the root directory path to the application, allows users today to modify the root path to application-conf.

Proposal is to provide more flexibility and externalise how the location of the application-conf directory is specified and let the engineering team define how it should look like. Even a hidden .zAppBuild directory could be a valid path in the application repository.

dennis-behm commented 10 months ago

Delivered via zAppBuild Release 3.4.0 (#392). Feedback welcome via #410