search

IBM / dbb-zappbuild

zAppBuild is a generic build solution for building z/OS applications using Apache Groovy build scripts and IBM Dependency Based Build (DBB) APIs.
Apache License 2.0
40 stars 123 forks source link

Fixing timestamp issue and adding decoration #425

Closed M-DLB closed 8 months ago

M-DLB commented 9 months ago

This PR is fixing the problem reported here, plus additional issues (error when displaying the list of input arguments, decoration to identify the different steps of the build process).

dennis-behm commented 9 months ago

@M-DLB Thank you for the updates.

https://github.com/M-DLB/dbb-zappbuild/blob/Fix-Timestamp/build-conf/build.properties#L108 defines also a valid time stamp. It is a bit of a "chicken and the egg" issue here, I guess, if we use the hard-coded vs the property-defined value.

Anyway, should we move to a 24-h format generally to be more consistent? We could simplify the code and remove the property.

M-DLB commented 9 months ago

I was not aware of this property! I think it makes sense to remove it, and only use the props.startTime to generate the build label. This would remove the buildOutputTSformat property. What do you mean by "24-h format generally to be more consistent"?

dennis-behm commented 8 months ago

Hi @M-DLB ,

What do you mean by "24-h format generally to be more consistent"?

The buildOutputTSformat has been added to use the 24 hour format yyyyMMdd.HHmmss.mmm for the build output directory, that when you sort the build output directory or the build label, it provides the correct chronological order (e.q. build.20231013.141258.012). Lower case hh in yyyyMMdd.hhmmss.mmm is the 12 hour format, leading to confusion.

I would rather go for the 24 format for all, then :-)