Handle exceptions thrown by the DBB runtime

IBM / dbb-zappbuild

zAppBuild is a generic build solution for building z/OS applications using Apache Groovy build scripts and IBM Dependency Based Build (DBB) APIs.

Apache License 2.0

40 stars 123 forks source link

Handle exceptions thrown by the DBB runtime #448

Closed dennis-behm closed 6 months ago

dennis-behm commented 7 months ago

This is implementing the #446 and #441 to improve the exception handling

Build exceptions in the language scripts, will be centrally handled.
When a build exception is caught, the build will finalise the build and skip any remaining elements on the build list.
Transfer.groovy will not continue the build, but properly stop processing the build.

dennis-behm commented 7 months ago

The latest commit also captures to handle any AssertionErrors that are thrown.

M-DLB commented 7 months ago

@dennis-behm I'm OK with the enhancements you did so far. There are still assertions that are not protected by try/catch blocks, for instance assertBuildProperties Although not related to the initial problem description, would it be possible to add missing try/catch when possible? :)

dennis-behm commented 7 months ago

Added a new zAppBuild test case for the Mortgage application to make sure that the code always runs through the finalisation of build process when there is a BuildException, that includes truncation errors or other build exceptions.

@M-DLB ready for a final review.