IBM / evote

A voting application that leverages Hyperledger Fabric and the IBM Blockchain Platform to record and tally ballots.
https://developer.ibm.com/patterns/how-to-create-a-secure-e-voting-application-on-hyperledger-fabric/
Apache License 2.0
324 stars 165 forks source link

Smart Contract Not Compatible with IBM Blockchain Platform 2.5 using Fabric 2.x Images #43

Open celder628 opened 4 years ago

celder628 commented 4 years ago

The smart contract uses an older shim level that is not supported with Hyperledger Fabric 2.x images.

Fabric runtimes that use Fabric 2.x images have Node version 12 instead of Node version 8 which is used in Fabric 1.4.x runtimes.

The smart contract fabric-contract-api & fabric-shim node modules must be at v1.4.5 or greater to work with Fabric 2.x images.

This is from the smart contract package.json:

"dependencies": { "fabric-contract-api": "1.4.1", "fabric-shim": "^1.4.1", "mem": "^5.1.1", "os-locale": "^4.0.0" },

This should be updated to:

"dependencies": { "fabric-contract-api": "1.4.5", "fabric-shim": "^1.4.5", "mem": "^5.1.1", "os-locale": "^4.0.0" },

horeaporutiu commented 4 years ago

@celder628 if you already have this working on your computer, could you make this PR?

celder628 commented 4 years ago

From what I can see, there are quite a few of these samples/demos. I cannot be responsible for the updates and retests needed for them all.

horeaporutiu commented 4 years ago

No - wasn't asking for all. Just this one - if you had a working sample. No problem. I will try and update it when I get a chance.