FedAvgLocalTrainingHandler forgot to update for pretrain/posttrain evaluation

IBM / federated-learning-lib

A library for federated learning (a distributed machine learning process) in an enterprise environment.

Other

500 stars 136 forks source link

FedAvgLocalTrainingHandler forgot to update for pretrain/posttrain evaluation #76

Open Hugomiralles opened 3 years ago

Hugomiralles commented 3 years ago

In class FedAvgLocalTrainingHandler in script party/training/fedavg_local_training_handler.py, I think there is a mistake. The two methods get_train_metrics_pre and get_train_metrics_post (of the inherited class LocalTrainingHandler) are not applied, resulting in no local metrics for the aggregated method FedAvg. Sorry for submitting an issue, I don't know how to make a pull request with whl files...

Yi-Zoey commented 3 years ago

Hi @Hugomiralles thanks for pointing out the bug. We are aware of it and working on improving the performance of the experimental manager.