IBM / fhe-toolkit-linux

IBM Fully Homomorphic Encryption Toolkit For Linux. This toolkit is a Linux based Docker container that demonstrates computing on encrypted data without decrypting it! The toolkit ships with two demos including a fully encrypted Machine Learning inference with a Neural Network and a Privacy-Preserving key-value search.
MIT License
1.44k stars 158 forks source link

Change bats library to bats-core #132

Closed boland25 closed 3 years ago

boland25 commented 3 years ago

Describe the bug Currently our ubuntu, fedora, and alpine libraries rely on bats in the package managers to install bats. However, we should be using bats-core To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

Additional context Add any other context about the problem here.

dowem commented 3 years ago

I think the patch addresses one of the distros but did it address all of them?

boland25 commented 3 years ago

Centos and alpine already had it setup this way. I originally relied on the package repos for Ubuntu and Fedora and they turned out to be the wrong package

dowem commented 3 years ago

OK then merged and closed! Thanks for slaying another issue @deanthomasson !