search

IBM / fhe-toolkit-macos

IBM Homomorphic Encryption Toolkit For MacOS
MIT License
360 stars 53 forks source link

Typo in the setup.sh script @ line 202 #65

Closed zrlsid closed 3 years ago

zrlsid commented 3 years ago

Describe the bug The setup.sh script does not build the HELib as there is a typo in the parameter list of the cmake command.

Current line @ 202: -DNTL_LIB="${DEPEND_DIR}/ntl/lib/ntl.a" \

The correct library path is actually: -DNTL_LIB="${DEPEND_DIR}/ntl/libs/ntl.a" \

note the s in the directory name libs

With this fix, it did build the HELib with the script.

dowem commented 3 years ago

@boland25 I just committed the fix to this to master. I wanted to point it out to you in case it had somehow slipped through testing. Thank you @zrlsid! Much appreciated Silvio!