search

IBM / gen-ai-rag-watsonx-sample-application

Sample application that uses generative AI RAG pattern. Deployment target on IBM Cloud and uses IBM watsonx.ai, watsonx Assistant and Watson Discovery services
Apache License 2.0
6 stars 6 forks source link

change image-name to app-name for docker image construction #17

Closed brendankellyibm closed 1 month ago

brendankellyibm commented 1 month ago

It seems that the image-name variable isn't automatically populated by the ALM DA, so I'm changing the construction of the image name to use app-name instead, which is available.

in-1911 commented 1 month ago

@brendankellyibm - I do see both app-name and image-name variable in the CI pipeline, but they have different values. What is the case for missing image-name? And can we instead do a fall-back to app-name in case image name is missing?

brendankellyibm commented 1 month ago

@in-1911 it's a good point - seems the ci_code_engine_image_name parameter controls this in the Code Engine version of the ALM DA, but there's no equivalent in the ROKS DA. I'll keep image-name for clarity and fallback to app-name, which is available in both versions.