search

IBM / go-sdk-core

The go-sdk-core repository contains core functionality required by Go code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
30 stars 24 forks source link

fix(IamAuthenticator): tweak Validate() method to be more lenient #158

Closed padamstx closed 2 years ago

padamstx commented 2 years ago

This commit adds a bit of leniency to the IamAuthenticator.Validate() method. We need to do this to ensure that a single authenticator instance can be shared among multiple service instances.

ibm-devx-sdk commented 2 years ago

:tada: This PR is included in version 5.9.5 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

mkumatag commented 2 years ago

This commit adds a bit of leniency to the IamAuthenticator.Validate() method. We need to do this to ensure that a single authenticator instance can be shared among multiple service instances.

finally! thanks for the fix @padamstx. IMO we should also demand IAM squad not return anything if no refresh token set, not_supported value doesn't make any sense to me.