search

IBM / go-sdk-core

The go-sdk-core repository contains core functionality required by Go code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
30 stars 24 forks source link

fix: BaseService.Request invoked without result does not close http.Response #176

Closed rafalbigaj closed 1 year ago

rafalbigaj commented 1 year ago

The method BaseService.Request invoked without result (nil) does not close http.Response and prevents connection to be put back into idle state.

We observed significant memory usage or quick MaxConnsPerHost limit exhaustion, when BaseService.Request is called with nil result.

Issue: https://github.com/IBM/go-sdk-core/issues/175

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

rafalbigaj commented 1 year ago

Thanks @padamstx! Is there a way to merge this fix to v5.10.x?

padamstx commented 1 year ago

Thanks @padamstx! Is there a way to merge this fix to v5.10.x?

If it is really needed there, then yes, I can work out a way to get it merged into the v5.10 release. But... the current 5.12.x release should be compatible. After I merge the PR into main (it will produce the 5.12.2 release), would you be able to try out that out to see if we can avoid applying the fix to 5.10.x?

ibm-devx-sdk commented 1 year ago

:tada: This PR is included in version 5.12.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: