search

IBM / go-sdk-core

The go-sdk-core repository contains core functionality required by Go code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
30 stars 24 forks source link

Update the RedactSecrets Regex to Support Satellite Storage Template Secret Parameter Names #190

Closed aayushsss1 closed 1 year ago

aayushsss1 commented 1 year ago

Due to current developments in providing Terraform support for satellite storage configurations, the names of secret parameters within storage templates that are used in the creation of these configurations are visible in the Terraform Logs and are required to be redacted. These secret parameters of storage templates vary in name depending on the provider (Eg : RedHat, AWS, Azure etc) and are as follows -

Redhat ibm-cos-access-key ibm-cos-secret-key iam-api-key kms-root-key kms-api-key

AWS aws-access-key aws-secret-access-key

Azure tenantId subscriptionId aadClientId aadClientSecret

Google
project_id private_key_id private_key client_email client_id auth_uri token_uri auth_provider_x509_cert_url client_x509_cert_url

IBM primary-gui-api-user primary-gui-api-password owning-gui-api-user owning-gui-api-password g2_api_key

NetApp username password

VMware vcenter-username vcenter-password thumbprint

A possible solution would be to add the following keywords to the existing regex -

key, secret, thumbprint, auth, project_id, client_id, client_email, tenantId, subscriptionId, aadClientId, aadClientSecret, auth_uri, token_uri, auth_provider_x509_cert_url, client_x509_cert_url

padamstx commented 1 year ago

PR: https://github.com/IBM/go-sdk-core/pull/191

ibm-devx-sdk commented 1 year ago

:tada: This issue has been resolved in version 5.14.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: