feat(BaseService): add new method ConfigureService() to BaseService struct

IBM / go-sdk-core

The go-sdk-core repository contains core functionality required by Go code generated by the IBM OpenAPI SDK Generator.

Apache License 2.0

30 stars 24 forks source link

feat(BaseService): add new method ConfigureService() to BaseService struct #35

Closed jorge-ibm closed 4 years ago

jorge-ibm commented 4 years ago

Fixes: https://github.ibm.com/arf/planning-sdk-squad/issues/1131

Changes:

moved the external configuration code outside of the constructor into it's own method.
for compatibility, the constructor calls the new method until we move to the service factory's complete implementation.

The new method will now be invoked from the generator after the BaseService's constructor is called. I have made the method public so it is accessible from the service instance.

CLAassistant commented 4 years ago

All committers have signed the CLA.

padamstx commented 4 years ago

One little comment about the commit message... when using the "feat:" prefix, if you use something like feat(BaseService): add new method ConfigureService() to BaseService struct then when semantic-release builds the changelog for the new release, it will group features together under the string inside the ()'s (i.e. BaseService).

jorge-ibm commented 4 years ago

thanks @padamstx , I actually didn't know that was a feature of semantic release

ibm-devx-automation commented 4 years ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: