IBM / go-sdk-core

The go-sdk-core repository contains core functionality required by Go code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
30 stars 24 forks source link

refactor: created new major version 3.0.0 in v3 directory #45

Closed padamstx closed 4 years ago

padamstx commented 4 years ago

This PR fixes our existing go core library so that it properly supports versioning with respect to Go modules. Specifically, this PR introduces a new major version (v3) which will be our starting point for correctly managing versions of the go core package. Ideally, we would have created a "v2" directory and added "/v2" to the end of the package name when we created the v2.0.0 major version, but due to inexperience with Go modules, this didn't happen. The recommended way to fix this is to simply introduce a new major version (v3 in our case) and start doing things correctly from this point forward.

The main changes are:

padamstx commented 4 years ago

I've tested this change in my go-test project (I updated the import paths in the go-test code to be github.com/IBM/go-sdk-core/v3/core and the new version (v3.0.0-rc1 in my case) was correctly found by the Go engine.